Added Class of device support and updated the config to use magic enum and Arduino IOT#375
Open
synapse-2 wants to merge 1 commit intoh2zero:masterfrom
Open
Added Class of device support and updated the config to use magic enum and Arduino IOT#375synapse-2 wants to merge 1 commit intoh2zero:masterfrom
synapse-2 wants to merge 1 commit intoh2zero:masterfrom
Conversation
…s for using magic enum and Arduino IOT support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
I have updated the lib to have the following
"Class of device" support spec from https://www.ampedrftech.com/datasheets/cod_definition.pdf when doing Bluetooth advertisement both 4.0 and 5.0 versions
Updated a define in the kconfig called “NIMBLE_USE_MAGIC_ENUM” which is by default set to false; it can be set to true if user wants to enable magic emum https://github.com/Neargye/magic_enum lib based log errors to be shown
When I used this lib with AurdinoIOT libs from (https://github.com/arduino-libraries/ArduinoIoTCloud) I got the error that READ and WRITE Enums are being redefined. Best way to change that is to use class based enums but that would break all items. So I created a new define NIMBLE_USING_ARDUINO_IOT which by default is set to false; when set to yes it will rename the NIMBLE_PROPERTY::READ to NIMBLE_PROPERTY::BLE_READ and NIMBLE_PROPERTY::WRITE to NIMBLE_PROPERTY::BLE_WRITE to avoid the clash